lkml.org 
[lkml]   [2024]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] i2c: Add a void pointer to i2c_device_id
On Mon, Apr 29, 2024 at 03:55:57PM +0200, Uwe Kleine-König wrote:
> On Mon, Apr 29, 2024 at 01:28:32PM +0300, Andy Shevchenko wrote:

..

> OK, agreed. I'm not sure yet if I prefer
>
> static const struct i2c_device_id wlf_gf_module_id[] = {
> { "wlf-gf-module" },
> { }
> };
>
> or
>
> static const struct i2c_device_id wlf_gf_module_id[] = {
> { .name = "wlf-gf-module" },
> { }
> };

Personally I don't care, but it seems in such cases the .name is too verbose
for no benefit. If one needs to expand this with driver data they will change
that line in any case.

--
With Best Regards,
Andy Shevchenko



\
 
 \ /
  Last update: 2024-05-27 18:08    [W:0.043 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site