Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 29 Apr 2024 15:47:05 +0200 | From | Sabrina Dubroca <> | Subject | Re: [PATCH net-next] net: loopback: Do not allocate tstats explicitly |
| |
(nit on the subject: you mention "tstats", but the code actually uses lstats. I guess that's not worth a v2)
2024-04-29, 01:55:58 -0700, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of in this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the loopback driver and leverage the network > core allocation instead. > > Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
-- Sabrina
| ![\](/images/icornerr.gif) |