Messages in this thread | | | Date | Mon, 29 Apr 2024 14:52:23 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2] net: dsa: mt7530: do not set MT7530_P5_DIS when PHY muxing is being used |
| |
On Sun, Apr 28, 2024 at 12:19:58PM +0300, Arınç ÜNAL via B4 Relay wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > DSA initalises the ds->num_ports amount of ports in > dsa_switch_touch_ports(). When the PHY muxing feature is in use, port 5 > won't be defined in the device tree. Because of this, the type member of > the dsa_port structure for this port will be assigned DSA_PORT_TYPE_UNUSED. > The dsa_port_setup() function calls ds->ops->port_disable() when the port > type is DSA_PORT_TYPE_UNUSED. > > The MT7530_P5_DIS bit is unset in mt7530_setup() when PHY muxing is being > used. mt7530_port_disable() which is assigned to ds->ops->port_disable() is > called afterwards. Currently, mt7530_port_disable() sets MT7530_P5_DIS > which breaks network connectivity when PHY muxing is being used. > > Therefore, do not set MT7530_P5_DIS when PHY muxing is being used. > > Fixes: 377174c5760c ("net: dsa: mt7530: move MT753X_MTRAP operations for MT7530") > Reported-by: Daniel Golle <daniel@makrotopia.org> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |