Messages in this thread | | | Date | Mon, 29 Apr 2024 18:23:51 -0700 | From | Dan Williams <> | Subject | Re: [PATCH v2 1/4] dax/bus.c: replace WARN_ON_ONCE() with lockdep asserts |
| |
Vishal Verma wrote: > In [1], Dan points out that all of the WARN_ON_ONCE() usage in the > referenced patch should be replaced with lockdep_assert_held, or > lockdep_held_assert_write(). Replace these as appropriate. > > Link: https://lore.kernel.org/r/65f0b5ef41817_aa222941a@dwillia2-mobl3.amr.corp.intel.com.notmuch [1] > Fixes: c05ae9d85b47 ("dax/bus.c: replace driver-core lock usage by a local rwsem") > Cc: Andrew Morton <akpm@linux-foundation.org> > Reported-by: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> > --- > drivers/dax/bus.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-)
Looks good,
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
| |