Messages in this thread | | | Date | Sat, 27 Apr 2024 18:37:43 +0100 | From | Simon Horman <> | Subject | Re: [PATCH net 3/4] net: qede: use return from qede_parse_flow_attr() for flow_spec |
| |
On Fri, Apr 26, 2024 at 09:12:25AM +0000, Asbjørn Sloth Tønnesen wrote: > In qede_flow_spec_to_rule(), when calling > qede_parse_flow_attr() then the return code > was only used for a non-zero check, and then > -EINVAL was returned. > > qede_parse_flow_attr() can currently fail with: > * -EINVAL > * -EOPNOTSUPP > * -EPROTONOSUPPORT > > This patch changes the code to use the actual > return code, not just return -EINVAL. > > The blaimed commit introduced qede_flow_spec_to_rule(), > and this call to qede_parse_flow_attr(), it looks > like it just duplicated how it was already used. > > Only compile tested. > > Fixes: 37c5d3efd7f8 ("qede: use ethtool_rx_flow_rule() to remove duplicated parser code") > Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
| |