lkml.org 
[lkml]   [2024]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error
On Fri, Apr 26, 2024 at 07:50:41PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 26, 2024 at 01:37:19PM -0300, Jason Gunthorpe wrote:
> > On Tue, Apr 23, 2024 at 11:42:58PM +0300, Andy Shevchenko wrote:
> > > The compilation with CONFIG_WERROR=y is broken:
> > >
> > > .../hw/mana/device.c:88:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> > > if (!upper_ndev) {
> > > ^~~~~~~~~~~
> > >
> > > Fix this by assigning the ret to -ENODEV in respective condition.
> > >
> > > Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > drivers/infiniband/hw/mana/device.c | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > This was fixed in
>
> Hmm... The below patch had been sent _after_ mine. What's wrong with
> mine patch?

It wasn't

Your's:
Date: Tue, 23 Apr 2024 23:42:58 +0300 [thread overview]

Konstantin's:
Date: Tue, 23 Apr 2024 07:15:51 -0700 [thread overview]

He beat you by 6 hours, which is why I took his, yours didn't exist at
the time I took it.

Jason

\
 
 \ /
  Last update: 2024-05-27 18:05    [W:0.048 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site