lkml.org 
[lkml]   [2024]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] dt-bindings: pinctrl: samsung: google,gs101-pinctrl needs a clock
    From
    On 26/04/2024 12:54, André Draszik wrote:
    > On Thu, 2024-04-25 at 20:18 +0200, Krzysztof Kozlowski wrote:
    >> On 25/04/2024 20:15, Krzysztof Kozlowski wrote:
    >>>> +      properties:
    >>>> +        compatible:
    >>>> +          contains:
    >>>> +            const: google,gs101-pinctrl
    >>>> +    then:
    >>>> +      required:
    >>>> +        - clocks
    >>>> +        - clock-names
    >>>
    >>> else:
    >>>   properties:
    >>>     clocks: false
    >>>     clock-names: false
    >>>
    >>> but anyway this is all a bit fragile, because pinctrl is not a driver
    >>> and you rely on initcall ordering.
    >>
    >> It is a driver, although initcall ordering is still there. Anyway, it's
    >> the first soc requiring clock for pinctrl
    >
    > If I see it right, E850 has similar gates, and like on gs101 they're currently
    > also all marked as CLK_IGNORE_UNUSED in the e850 clock driver with a comment that
    > a driver update is needed. I've added Sam.

    Cool, so this should solve also Sam's problem. Sam, can you test the
    patchset in spare time?

    Best regards,
    Krzysztof


    \
     
     \ /
      Last update: 2024-05-27 18:04    [W:8.803 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site