Messages in this thread | | | Date | Fri, 26 Apr 2024 12:34:47 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v8 2/6] cpufreq: amd-pstate: initialize new core precision boost state |
| |
On Fri, Apr 26, 2024 at 02:34:45PM +0800, Perry Yuan wrote: > @@ -665,18 +667,31 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) > return 0; > } > > -static void amd_pstate_boost_init(struct amd_cpudata *cpudata) > +static int amd_pstate_boost_init(struct amd_cpudata *cpudata) > { > - u32 highest_perf, nominal_perf; > + u64 boost_val; > + int ret; > > - highest_perf = READ_ONCE(cpudata->highest_perf); > - nominal_perf = READ_ONCE(cpudata->nominal_perf); > + if (!boot_cpu_has(X86_FEATURE_CPB)) {
Repeat after me:
Everytime I need to test a X86_FEATURE flag, I will use cpu_feature_enabled()! Everytime I need to test a X86_FEATURE flag, I will use cpu_feature_enabled()! Everytime I need to test a X86_FEATURE flag, I will use cpu_feature_enabled()! Everytime I need to test a X86_FEATURE flag, I ...
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |