lkml.org 
[lkml]   [2024]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 1/3] drm/panel: ili9341: Correct use of device property APIs
    Date
    It seems driver missed the point of proper use of device property APIs.
    Correct this by updating headers and calls respectively.

    Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver")
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/gpu/drm/panel/Kconfig | 2 +-
    drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 5 +++--
    2 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
    index e54f6f5604ed..2d4515555820 100644
    --- a/drivers/gpu/drm/panel/Kconfig
    +++ b/drivers/gpu/drm/panel/Kconfig
    @@ -177,7 +177,7 @@ config DRM_PANEL_ILITEK_IL9322

    config DRM_PANEL_ILITEK_ILI9341
    tristate "Ilitek ILI9341 240x320 QVGA panels"
    - depends on OF && SPI
    + depends on SPI
    select DRM_KMS_HELPER
    select DRM_GEM_DMA_HELPER
    depends on BACKLIGHT_CLASS_DEVICE
    diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
    index 3574681891e8..7584ddb0e441 100644
    --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
    +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
    @@ -22,8 +22,9 @@
    #include <linux/bitops.h>
    #include <linux/delay.h>
    #include <linux/gpio/consumer.h>
    +#include <linux/mod_devicetable.h>
    #include <linux/module.h>
    -#include <linux/of.h>
    +#include <linux/property.h>
    #include <linux/regulator/consumer.h>
    #include <linux/spi/spi.h>

    @@ -691,7 +692,7 @@ static int ili9341_dpi_probe(struct spi_device *spi, struct gpio_desc *dc,
    * Every new incarnation of this display must have a unique
    * data entry for the system in this driver.
    */
    - ili->conf = of_device_get_match_data(dev);
    + ili->conf = device_get_match_data(dev);
    if (!ili->conf) {
    dev_err(dev, "missing device configuration\n");
    return -ENODEV;
    --
    2.43.0.rc1.1336.g36b5255a03ac

    \
     
     \ /
      Last update: 2024-05-27 18:02    [W:4.150 / U:0.736 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site