Messages in this thread | | | Date | Tue, 23 Apr 2024 15:49:23 +0200 | From | Jan Kara <> | Subject | Re: [PATCH -next] cgroup: Introduce css_is_online() helper |
| |
On Sat 20-04-24 09:44:28, Xiu Jianfeng wrote: > Introduce css_is_online() helper to test if whether the specified > css is online, avoid testing css.flags with CSS_ONLINE directly > outside of cgroup.c. > > Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
One style nit below:
> +/* > + * css_is_online - test whether the specified css is online > + * @css: target css > + */ > +static inline bool css_is_online(struct cgroup_subsys_state *css) > +{ > + return !!(css->flags & CSS_ONLINE); > +}
Since the return type is 'bool', you don't need the !! magic in the statement above.
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |