Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 23 Apr 2024 15:20:44 +0200 | Subject | Re: [PATCH v3 3/3] arm64: dts: qcom: Add initial support for rb5gen2 board | From | Konrad Dybcio <> |
| |
On 3/13/24 08:12, Wasim Nazir wrote: > RB5gen2 is based on QCS8550-Rb5gen2 SOM for IOT solutions. > This initial version describes VPH_PWR, UART & USB3.1(HS). > > On-board PMICs: > - PMR735D > - PM8010 > > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com> >
Where's the "---"? :thinking:
[...]
> +&apps_rsc { > + regulators-0 {
This does not scale. Use &label references instead
> + vdd-bob1-supply = <&vph_pwr>; > + vdd-bob2-supply = <&vph_pwr>; > + }; > + > + regulators-2 { > + vdd-s4-supply = <&vph_pwr>; > + vdd-s5-supply = <&vph_pwr>; > + }; > + > + regulators-3 { > + vdd-s1-supply = <&vph_pwr>; > + vdd-s3-supply = <&vph_pwr>; > + vdd-s4-supply = <&vph_pwr>; > + vdd-s5-supply = <&vph_pwr>; > + vdd-s6-supply = <&vph_pwr>; > + }; > + > + regulators-4 { > + vdd-s1-supply = <&vph_pwr>; > + vdd-s3-supply = <&vph_pwr>; > + vdd-s4-supply = <&vph_pwr>; > + vdd-s5-supply = <&vph_pwr>; > + vdd-s7-supply = <&vph_pwr>; > + }; > + > + regulators-5 { > + vdd-s1-supply = <&vph_pwr>; > + vdd-s2-supply = <&vph_pwr>; > + vdd-s3-supply = <&vph_pwr>; > + vdd-s4-supply = <&vph_pwr>; > + vdd-s5-supply = <&vph_pwr>; > + vdd-s6-supply = <&vph_pwr>; > + }; > +}; > + > +&pm8550b_eusb2_repeater { > + vdd18-supply = <&vreg_l15b_1p8>; > + vdd3-supply = <&vreg_l5b_3p1>; > +};
Would that not be SoM-common too?
Konrad
| ![\](/images/icornerr.gif) |