Messages in this thread | | | Date | Tue, 23 Apr 2024 15:11:08 +0200 | Subject | Re: [PATCH v2 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Enable USB role switching | From | Konrad Dybcio <> |
| |
On 3/29/24 13:26, Luca Weiss wrote: > Configure the Type-C and VBUS regulator on PM7250B and wire it up to the > USB PHY, so that USB role and orientation switching works. > > For now USB Power Delivery properties are skipped / disabled, so that > the (presumably) bootloader-configured charger doesn't get messed with > and we can charge the phone with at least some amount of power. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
nits:
> + usb-role-switch;
this is a common property of the dwc3 host
[...]
> vdda-phy-supply = <&vreg_l22a>; > vdda-pll-supply = <&vreg_l16a>; > + orientation-switch;
and this is a common property of the QMPPHY
Could you move them to the node definition?
Konrad
| |