lkml.org 
[lkml]   [2024]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/10] x86/rcu: Add rcu_preempt_count
    Le Tue, Apr 23, 2024 at 05:02:35PM +0800, Lai Jiangshan a écrit :
    > Hello, Frederic
    >
    > Thanks for reviewing.
    >
    > On Mon, Apr 22, 2024 at 7:05 PM Frederic Weisbecker <frederic@kernel.org> wrote:
    >
    > > > +
    > > > +/* We use the MSB mostly because its available */
    > >
    > > I think you can safely remove the "We " from all the comments :-)
    >
    > The file is mainly copied from arch/x86/include/asm/preempt.h.
    > I will rephrase sentences in later iterations.
    >
    > >
    > > > +#define RCU_PREEMPT_UNLOCK_SPECIAL_INVERTED 0x80000000
    > >
    > > How about RCU_PREEMPT_UNLOCK_FASTPATH ?
    >
    >
    > I'm not good at naming. But the MSB really means exactly the opposite
    > of current->rcu_read_unlock_special and I think "UNLOCK_SPECIAL_INVERTED"
    > fits the meaning.

    Right but I tend to think a constant should tell what something is, not what
    something is not.

    FWIW, p->rcu_read_unlock_special could even be renamed to p->rcu_read_unlock_slowpath

    Thanks.

    \
     
     \ /
      Last update: 2024-05-27 17:58    [W:4.654 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site