Messages in this thread | | | Subject | Re: [PATCH net-next v2 7/8] net: ipa: fix two minor ipa_cmd problems | From | Paolo Abeni <> | Date | Tue, 23 Apr 2024 13:21:35 +0200 |
| |
On Fri, 2024-04-19 at 10:17 -0500, Alex Elder wrote: > In "ipa_cmd.h", ipa_cmd_data_valid() is declared, but that function > does not exist. So delete that declaration. > > Also, for some reason ipa_cmd_init() never gets called. It isn't > really critical--it just validates that some memory offsets and a > size can be represented in some register fields, and they won't fail > with current data. Regardless, call the function in ipa_probe().
That name sounds confusing to me: I expect *init to allocate/set something that will need some reverse operation at shutdown/removal. What about a possible follow-up renaming the function to ipa_cmd_validate() or the like?
Not blocking the series, I'm applying it.
Thanks,
Paolo
| |