Messages in this thread | | | Date | Tue, 23 Apr 2024 12:15:18 +0100 | From | Simon Horman <> | Subject | Re: [ovs-dev] [PATCH net-next] net: openvswitch: Release reference to netdev |
| |
+ David Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Eelco Chaudron
On Tue, Apr 23, 2024 at 03:37:51PM +0800, Jun Gu wrote: > dev_get_by_name will provide a reference on the netdev. So ensure that > the reference of netdev is released after completed. > > Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name") > Signed-off-by: Jun Gu <jun.gu@easystack.cn>
Hi Jun Gu,
This change looks good to me.
Unfortunately didn't seem to hit netdev for some reason.
And, probably unrelated to that some CCs were missing: they should be seeded using ./scripts/get_maintainer.pl my.patch
I'd wait for feedback from Jakub on if a repost is needed (because for one thing it's not good to repost within 24h.)
The above notwithstanding,
Reviewed-by: Simon Horman <horms@kernel.org>
> --- > net/openvswitch/vport-netdev.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c > index 618edc346c0f..91a11067e458 100644 > --- a/net/openvswitch/vport-netdev.c > +++ b/net/openvswitch/vport-netdev.c > @@ -78,12 +78,16 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name) > int err; > > vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name); > + if (!vport->dev) { > + err = -ENODEV; > + goto error_free_vport; > + } > /* Ensure that the device exists and that the provided > * name is not one of its aliases. > */ > - if (!vport->dev || strcmp(name, ovs_vport_name(vport))) { > + if (strcmp(name, ovs_vport_name(vport))) { > err = -ENODEV; > - goto error_free_vport; > + goto error_put; > } > netdev_tracker_alloc(vport->dev, &vport->dev_tracker, GFP_KERNEL); > if (vport->dev->flags & IFF_LOOPBACK || > -- > 2.25.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
| |