Messages in this thread | | | Date | Tue, 23 Apr 2024 00:43:55 +0200 | Subject | Re: [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator | From | Konrad Dybcio <> |
| |
On 4/18/24 12:03, Luca Weiss wrote: > On Thu Apr 18, 2024 at 12:01 PM CEST, Konrad Dybcio wrote: >> On 18.04.2024 8:36 AM, Luca Weiss wrote: >>> Add a node for the vibrator module found inside the PMI632. >>> >>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >>> --- >> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> >> On a side note, this is a totally configuration-free peripheral that doesn't do >> anything crazy until manually configured. >> >> In the slow quest to be (hopefully) more sane about the defaults, should we keep >> them enabled by default? Bjorn? > > But many (most?) devices don't have a vibration motor connected to > PMI632, some (like devboards) don't have anything, and other phones have > a separate chip that controls the vibration motor. > > Enabling this by default would mean all devices with PMI632 would get an > input device for the vibrator that probably doesn't work?
Fair
Konrad
| |