lkml.org 
[lkml]   [2024]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 5/6] sparc/init: Remove on-stack cpumask var
    Date
    In general it's preferable to avoid placing cpumasks on the stack, as
    for large values of NR_CPUS these can consume significant amounts of
    stack space and make stack overflows more likely.

    Since the cpumask var resides in __init function, which means it's free
    of any concurrenct access, it can be safely marked with static to get
    rid of allocation on stack.

    Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
    ---
    arch/sparc/mm/init_64.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
    index 1ca9054d9b97..9edbf57a2c59 100644
    --- a/arch/sparc/mm/init_64.c
    +++ b/arch/sparc/mm/init_64.c
    @@ -1438,7 +1438,7 @@ static int __init numa_attach_mlgroup(struct mdesc_handle *md, u64 grp,
    static int __init numa_parse_mdesc_group(struct mdesc_handle *md, u64 grp,
    int index)
    {
    - cpumask_t mask;
    + static cpumask_t mask;
    int cpu;

    numa_parse_mdesc_group_cpus(md, grp, &mask);
    --
    2.27.0

    \
     
     \ /
      Last update: 2024-05-27 17:57    [W:2.293 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site