Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Andy Shevchenko <> | Subject | [PATCH v2 3/3] kfifo: Don't use "proxy" headers | Date | Tue, 23 Apr 2024 22:23:10 +0300 |
| |
Update header inclusions to follow IWYU (Include What You Use) principle.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/kfifo.h | 9 +++++++-- lib/kfifo.c | 10 +++++----- samples/kfifo/dma-example.c | 3 ++- 3 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index 0b35a41440ff..6b28d642f332 100644 --- a/include/linux/kfifo.h +++ b/include/linux/kfifo.h @@ -36,10 +36,15 @@ * to lock the reader. */ -#include <linux/kernel.h> +#include <linux/array_size.h> #include <linux/spinlock.h> #include <linux/stddef.h> -#include <linux/scatterlist.h> +#include <linux/types.h> + +#include <asm/barrier.h> +#include <asm/errno.h> + +struct scatterlist; struct __kfifo { unsigned int in; diff --git a/lib/kfifo.c b/lib/kfifo.c index 12f5a347aa13..15acdee4a8f3 100644 --- a/lib/kfifo.c +++ b/lib/kfifo.c @@ -5,13 +5,13 @@ * Copyright (C) 2009/2010 Stefani Seibold <stefani@seibold.net> */ -#include <linux/kernel.h> -#include <linux/export.h> -#include <linux/slab.h> #include <linux/err.h> -#include <linux/log2.h> -#include <linux/uaccess.h> +#include <linux/export.h> #include <linux/kfifo.h> +#include <linux/log2.h> +#include <linux/scatterlist.h> +#include <linux/slab.h> +#include <linux/uaccess.h> /* * internal helper to calculate the unused elements in a fifo diff --git a/samples/kfifo/dma-example.c b/samples/kfifo/dma-example.c index 0cf27483cb36..74fe915b7ffe 100644 --- a/samples/kfifo/dma-example.c +++ b/samples/kfifo/dma-example.c @@ -6,8 +6,9 @@ */ #include <linux/init.h> -#include <linux/module.h> #include <linux/kfifo.h> +#include <linux/module.h> +#include <linux/scatterlist.h> /* * This module shows how to handle fifo dma operations. -- 2.43.0.rc1.1336.g36b5255a03ac
| ![\](/images/icornerr.gif) |