Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 23 Apr 2024 17:31:58 +0200 | Subject | Re: [PATCH v5 01/11] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq() |
| |
Hi Thomas,
On Tue, Apr 23, 2024 at 12:53 PM Thomas Richard <thomas.richard@bootlin.com> wrote: > On 4/23/24 12:34, Andy Shevchenko wrote: > > On Tue, Apr 23, 2024 at 12:42 PM Geert Uytterhoeven > > <geert@linux-m68k.org> wrote: > >> On Tue, Apr 16, 2024 at 3:31 PM Thomas Richard > >> <thomas.richard@bootlin.com> wrote: > > > > ... > > > >> +i2c-rcar e66d8000.i2c: error -16 : 10000005 > > > > It probably means that I²C host controller is already in power off > > mode and can't serve anymore. > > Yes the i2c controller is already off. > In fact it's the same issue I had with the i2c-omap driver. > In suspend-noirq, the runtime pm is disabled, so you can't wakeup a > device. More details available in this thread [1]. > So the trick is to wakeup the device during suspend (like I did for the > i2c-omap driver [2]. > > [1] > https://lore.kernel.org/all/f68c9a54-0fde-4709-9d2f-0d23a049341b@bootlin.com/ > [2] > https://lore.kernel.org/all/20240102-j7200-pcie-s2r-v5-2-4b8c46711ded@bootlin.com/ > > I think the patch below should fix the issue.
Thanks, I gave that a try, but it doesn't make any difference.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |