lkml.org 
[lkml]   [2024]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 0/2] Add adm1281 support
Date
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Monday, April 22, 2024 11:45 AM
> To: Krzysztof Kozlowski <krzk@kernel.org>; SanBuenaventura, Jose
> <Jose.SanBuenaventura@analog.com>; linux-hwmon@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> doc@vger.kernel.org; linux-i2c@vger.kernel.org
> Cc: Jean Delvare <jdelvare@suse.com>; Rob Herring <robh@kernel.org>;
> Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>; Jonathan Corbet <corbet@lwn.net>; Delphine CC
> Chiu <Delphine_CC_Chiu@Wiwynn.com>
> Subject: Re: [PATCH v2 0/2] Add adm1281 support
>
> [External]
>
> On 4/21/24 20:28, Krzysztof Kozlowski wrote:
> > On 22/04/2024 04:51, Jose Ramon San Buenaventura wrote:
> >> This patch removes the extra case added in the adm1275_read_byte_data
> >> for STATUS_CML reads. Upon checking, the reads for the STATUS_CML
> >> register is already handled in the pmbus_core.
> >>
> >> It was also clarified and agreed upon that any other actionable steps
> >> involving the STATUS_CML error flags should be added in the
> >> pmbus_core and not on the specific chip driver.
> >>
> >
> > Where is the changelog? It's v2, so what happened here?
> >
>
> Same question.
>
> Guenter
>

Hello,

The only change from v1 to v2 is the removal of the additional case
for STATUS_CML in the adm1275_read_byte_data function in the adm1275.c
driver code. No changes were done in the other files, only in the driver code.

I apologize for the confusion.

For clarification, do I need to resend the patches and include a changelog
in the patch that specifies the changes done i.e., v1 -> v2: removed case?

Joram
\
 
 \ /
  Last update: 2024-05-27 17:55    [W:0.046 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site