lkml.org 
[lkml]   [2024]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] dt-bindings: usb: uhci: convert to dt schema
From
On 22/04/2024 11:37, Mohammad Shehar Yaar Tausif wrote:
> Convert USB UHCI bindings to DT schema.

Please mention changes from pure conversion, so documenting aspeed
compatibles and missing properties.

>
> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
> ---

..

..

> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +if:

This should be under allOf

> + properties:
> + compatible:
> + contains:
> + const: generic-uhci
> +then:
> + allOf:
> + - $ref: usb-hcd.yaml

This is confusing. Aspeed is not different here.

> + if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - aspeed,ast2400-uhci
> + - aspeed,ast2500-uhci
> + - aspeed,ast2600-uhci
> + then:
> + properties:
> + '#ports':
> + $ref: /schemas/types.yaml#/definitions/uint32

And the #ports property looks valid for generic-ahci. Why do you think
it is not valid?


> + clocks:
> + maxItems: 1

Define properties top-level.

> + required:
> + - clocks

This looks required for generic-uhci as well. Why did you put it only
for aspeed?


Best regards,
Krzysztof


\
 
 \ /
  Last update: 2024-05-27 17:55    [W:0.146 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site