Messages in this thread | | | From | Alice Ryhl <> | Date | Mon, 22 Apr 2024 11:25:45 +0200 | Subject | Re: [PATCH] kbuild: rust: remove unneeded `@rustc_cfg` to avoid ICE |
| |
On Mon, Apr 22, 2024 at 11:13 AM Miguel Ojeda <ojeda@kernel.org> wrote: > > When KUnit tests are enabled, under very big kernel configurations > (e.g. `allyesconfig`), we can trigger a `rustdoc` ICE [1]: > > RUSTDOC TK rust/kernel/lib.rs > error: the compiler unexpectedly panicked. this is a bug. > > The reason is that this build step has a duplicated `@rustc_cfg` argument, > which contains the kernel configuration, and thus a lot of arguments. The > factor 2 happens to be enough to reach the ICE. > > Thus remove the unneeded `@rustc_cfg`. By doing so, we clean up the > command and workaround the ICE. > > The ICE has been fixed in the upcoming Rust 1.79 [2]. > > Cc: stable@vger.kernel.org > Fixes: a66d733da801 ("rust: support running Rust documentation tests as KUnit ones") > Link: https://github.com/rust-lang/rust/issues/122722 [1] > Link: https://github.com/rust-lang/rust/pull/122840 [2] > Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
| |