Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 22 Apr 2024 11:06:55 +0200 | Subject | Re: [PATCH 2/2] arm64: dts: rockchip: add dual-role usb3 hosts to rk3588 Tiger-Haikou | From | Quentin Schulz <> |
| |
Hi Heiko,
On 4/18/24 23:03, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > Apart from the host-only usb3 controller (host2) the rk3588 also provides > two dual-role controllers. On the Tiger-Haikou combination these are > connected to the lower usb3-host port in host-only mode and the micro-usb3 > port for dual-role operation. > > Add the necessary controllers, phys and usb-id extcon to the Tiger-Haikou > board. The Q7 standard defines the pin as usb-id, but it will only ever > get used if the baseboard actually provides an OTG port. So the extcon > stays disabled in the dtsi and only gets enabled in the haikou dts. > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
Would have preferred two separate commits but the content is fine and it's not that difficult to review, so
Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Thanks, Quentin
| ![\](/images/icornerr.gif) |