Messages in this thread | | | Date | Mon, 22 Apr 2024 09:50:40 +0200 | From | Neil Armstrong <> | Subject | Re: [PATCH 00/15] tty: serial: switch from circ_buf to kfifo |
| |
Hi Greg,
On 20/04/2024 07:42, Greg KH wrote: > On Fri, Apr 19, 2024 at 05:12:28PM +0200, Neil Armstrong wrote: >> This patchset has at least broken all Amlogic and Qualcomm boards so >> far, only part of them were fixed in next- but this serie has been >> merged in v1 with no serious testing and should've been dropped >> immediately when the first regressions were reported. > > What is not yet fixed with the recent patch that was just sent to the > list? > > Doing core changes like this is hard, I have seen no lack of willingness > to fix reported problems or major breakages that would deserve a revert.
It broken all Amlogic and Qualcomm boards, are we sure it didn't break other systems that are not CI tested on -next ?
This serie clearly deserved a v2, patch 11 wasn't seriously reviewed, and it deserved a ping on the RFT before sending a v1.
I don't understand why speeding up this changeset and applying it without any reviews nor tests was so important.
Thanks, Neil > > greg k-h
| |