Messages in this thread | | | From | Ricardo Ribalda <> | Date | Mon, 22 Apr 2024 14:52:43 +0800 | Subject | Re: [PATCH v2 06/26] media: stm32-dcmipp: Remove redundant printk |
| |
Hi Bryan
Thanks for your review
On Sun, 21 Apr 2024 at 07:15, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 19/04/2024 10:47, Ricardo Ribalda wrote: > > - if (irq <= 0) { > <snip> > > - return irq ? irq : -ENXIO; > > - } > > You're dropping the original intent of the driver author there no ? when > irq == 0 they want to return -ENXIO.
platform_get_irq() can never return 0. https://lore.kernel.org/linux-media/cd4aac19-c4cf-4db0-a18c-42f1bf1441a8@moroto.mountain/
Let me add that to the commit message.
Thanks!
> > --- > bod
-- Ricardo Ribalda
| |