Messages in this thread | | | From | Ian Rogers <> | Date | Mon, 22 Apr 2024 13:59:27 -0700 | Subject | Re: [PATCH v3 00/12] dso/dsos memory savings and clean up |
| |
On Mon, Apr 22, 2024 at 1:55 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > On Mon, Apr 22, 2024 at 01:06:46PM -0700, Namhyung Kim wrote: > > On Thu, Apr 11, 2024 at 11:42 AM Arnaldo Carvalho de Melo > > <acme@kernel.org> wrote: > > > > > > On Tue, Apr 09, 2024 at 11:42:02PM -0700, Ian Rogers wrote: > > > > 12 more patches from: > > > > https://lore.kernel.org/lkml/20240202061532.1939474-1-irogers@google.com/ > > > > a near half year old adventure in trying to lower perf's dynamic > > > > memory use. Bits like the memory overhead of opendir are on the > > > > sidelines for now, too much fighting over how > > > > distributions/C-libraries present getdents. These changes are more > > > > good old fashioned replace an rb-tree with a sorted array and add > > > > reference count tracking. > > > > > > > > The changes migrate dsos code, the collection of dso structs, more > > > > into the dsos.c/dsos.h files. As with maps and threads, this is done > > > > so the internals can be changed - replacing a linked list (for fast > > > > iteration) and an rb-tree (for fast finds) with a lazily sorted > > > > array. The complexity of operations remain roughly the same, although > > > > iterating an array is likely faster than iterating a linked list, the > > > > memory usage is at least reduce by half. > > > > > > Got the first 5 patches, would be nice if more people could review it, > > > I'll try and get back to is soon. > > > > For the series: > > > > Acked-by: Namhyung Kim <namhyung@kernel.org> > > It is not applying right now, I've just merged with torvalds/master and > I'm running build tests now, will push to tmp.perf-tools-next right now.
Ok, do you want me to rebase on tmp.perf-tools-next?
Thanks, Ian
> - Arnaldo
| |