lkml.org 
[lkml]   [2024]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/7] PCI: xilinx-nwl: Rate-limit misc interrupt messages
    Date
    The conditions logged by the misc interrupt can occur repeatedly and
    continuously. Avoid rendering the console unusable by rate-limiting
    these messages.

    Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
    ---

    drivers/pci/controller/pcie-xilinx-nwl.c | 22 +++++++++++-----------
    1 file changed, 11 insertions(+), 11 deletions(-)

    diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c
    index ce881baac6d8..c0a60cebdb2e 100644
    --- a/drivers/pci/controller/pcie-xilinx-nwl.c
    +++ b/drivers/pci/controller/pcie-xilinx-nwl.c
    @@ -267,37 +267,37 @@ static irqreturn_t nwl_pcie_misc_handler(int irq, void *data)
    return IRQ_NONE;

    if (misc_stat & MSGF_MISC_SR_RXMSG_OVER)
    - dev_err(dev, "Received Message FIFO Overflow\n");
    + dev_err_ratelimited(dev, "Received Message FIFO Overflow\n");

    if (misc_stat & MSGF_MISC_SR_SLAVE_ERR)
    - dev_err(dev, "Slave error\n");
    + dev_err_ratelimited(dev, "Slave error\n");

    if (misc_stat & MSGF_MISC_SR_MASTER_ERR)
    - dev_err(dev, "Master error\n");
    + dev_err_ratelimited(dev, "Master error\n");

    if (misc_stat & MSGF_MISC_SR_I_ADDR_ERR)
    - dev_err(dev, "In Misc Ingress address translation error\n");
    + dev_err_ratelimited(dev, "In Misc Ingress address translation error\n");

    if (misc_stat & MSGF_MISC_SR_E_ADDR_ERR)
    - dev_err(dev, "In Misc Egress address translation error\n");
    + dev_err_ratelimited(dev, "In Misc Egress address translation error\n");

    if (misc_stat & MSGF_MISC_SR_FATAL_AER)
    - dev_err(dev, "Fatal Error in AER Capability\n");
    + dev_err_ratelimited(dev, "Fatal Error in AER Capability\n");

    if (misc_stat & MSGF_MISC_SR_NON_FATAL_AER)
    - dev_err(dev, "Non-Fatal Error in AER Capability\n");
    + dev_err_ratelimited(dev, "Non-Fatal Error in AER Capability\n");

    if (misc_stat & MSGF_MISC_SR_CORR_AER)
    - dev_err(dev, "Correctable Error in AER Capability\n");
    + dev_err_ratelimited(dev, "Correctable Error in AER Capability\n");

    if (misc_stat & MSGF_MISC_SR_UR_DETECT)
    - dev_err(dev, "Unsupported request Detected\n");
    + dev_err_ratelimited(dev, "Unsupported request Detected\n");

    if (misc_stat & MSGF_MISC_SR_NON_FATAL_DEV)
    - dev_err(dev, "Non-Fatal Error Detected\n");
    + dev_err_ratelimited(dev, "Non-Fatal Error Detected\n");

    if (misc_stat & MSGF_MISC_SR_FATAL_DEV)
    - dev_err(dev, "Fatal Error Detected\n");
    + dev_err_ratelimited(dev, "Fatal Error Detected\n");

    if (misc_stat & MSGF_MISC_SR_LINK_AUTO_BWIDTH)
    dev_info(dev, "Link Autonomous Bandwidth Management Status bit set\n");
    --
    2.35.1.1320.gc452695387.dirty

    \
     
     \ /
      Last update: 2024-05-27 17:56    [W:5.290 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site