lkml.org 
[lkml]   [2024]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] cgroup/cpuset: Statically initialize more members of top_cpuset
From

On 4/20/24 05:46, Xiu Jianfeng wrote:
> Initializing top_cpuset.relax_domain_level and setting
> CS_SCHED_LOAD_BALANCE to top_cpuset.flags in cpuset_init() could be
> completed at the time of top_cpuset definition by compiler.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> kernel/cgroup/cpuset.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index d8d3439eda4e..e70008a1d86a 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -369,8 +369,9 @@ static inline void notify_partition_change(struct cpuset *cs, int old_prs)
>
> static struct cpuset top_cpuset = {
> .flags = ((1 << CS_ONLINE) | (1 << CS_CPU_EXCLUSIVE) |
> - (1 << CS_MEM_EXCLUSIVE)),
> + (1 << CS_MEM_EXCLUSIVE) | (1 < CS_SCHED_LOAD_BALANCE)),
> .partition_root_state = PRS_ROOT,
> + .relax_domain_level = -1,
> .remote_sibling = LIST_HEAD_INIT(top_cpuset.remote_sibling),
> };
>
> @@ -4309,8 +4310,6 @@ int __init cpuset_init(void)
> nodes_setall(top_cpuset.effective_mems);
>
> fmeter_init(&top_cpuset.fmeter);
> - set_bit(CS_SCHED_LOAD_BALANCE, &top_cpuset.flags);
> - top_cpuset.relax_domain_level = -1;
> INIT_LIST_HEAD(&remote_children);
>
> BUG_ON(!alloc_cpumask_var(&cpus_attach, GFP_KERNEL));
Reviewed-by: Waiman Long <longman@redhat.com>


\
 
 \ /
  Last update: 2024-05-27 17:56    [W:0.048 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site