Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v5 1/4] rust: uaccess: add userspace pointers | Date | Sun, 21 Apr 2024 19:48:31 +0000 |
| |
From: Alice Ryhl > Sent: 21 April 2024 19:38 > > On Sun, Apr 21, 2024 at 8:08 PM David Laight <David.Laight@aculab.com> wrote: > > > > Should you be implementing 'struct iov_iter' ? > > > > Even if it means creating an IO_UBUF for ioctls? > > (Although that might take some 'fettling' for read+write for ioctls.) > > That seems to be intended for when you have several chunks of memory > in userspace that you want to treat as one contiguous chunk. That's > not something I need in the Android Binder driver.
It also transparently supports in-kernel users and some other cases.
I think there is a patch intended for 6.10 that removes the 'read' and 'write' driver 'ops' and requires that drivers support 'read_iter' and 'write_iter'.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |