Messages in this thread Patch in this message | | | Subject | Re: [PATCH v2] remove indentation for common path [linux-next] | From | Joe Perches <> | Date | Sat, 20 Apr 2024 10:07:47 -0700 |
| |
On Sat, 2024-04-20 at 22:19 +0530, sundar wrote:
> ``` Added check if pointer is null and removed indentation for common path ```
[]
> ``` diff --git a/drivers/usb/typec/mux/nb7vpq904m.c b/drivers/usb/typec/mux/nb7vpq904m.c ```
[]
> ``` @@ -321,35 +321,37 @@ static int nb7vpq904m_parse_data_lanes_mapping(struct nb7vpq904m *nb7) ep = of_graph_get_endpoint_by_regs(nb7->client->dev.of_node, 1, 0); - if (ep) { - ret = of_property_count_u32_elems(ep, "data-lanes"); - if (ret == -EINVAL) - /* Property isn't here, consider default mapping */ - goto out_done; - if (ret < 0) - goto out_error; - - if (ret != DATA_LANES_COUNT) { - dev_err(&nb7->client->dev, "expected 4 data lanes\n"); - ret = -EINVAL; - goto out_error; - } + if (!ep) + return 0; ```
Not equivalent code as the out_error:
of_node_put(ep);
isn't done
| |