Messages in this thread | | | Date | Tue, 2 Apr 2024 14:41:24 +0200 | Subject | Re: [PATCH net-next v2 1/2] net/iucv: Avoid explicit cpumask var allocation on stack | From | Alexandra Winter <> |
| |
On 31.03.24 07:34, Dawei Li wrote: > For CONFIG_CPUMASK_OFFSTACK=y kernel, explicit allocation of cpumask > variable on stack is not recommended since it can cause potential stack > overflow. > > Instead, kernel code should always use *cpumask_var API(s) to allocate > cpumask var in config-neutral way, leaving allocation strategy to > CONFIG_CPUMASK_OFFSTACK. > > Use *cpumask_var API(s) to address it. > > Signed-off-by: Dawei Li <dawei.li@shingroup.cn> > ---
LGTM; Thank you Eric for the comment and solution with the 'static' keyword. Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
| |