Messages in this thread | | | From | Akhil R <> | Subject | RE: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver | Date | Tue, 2 Apr 2024 12:36:41 +0000 |
| |
> On Tue, Mar 19, 2024 at 01:53:04PM +0530, Akhil R wrote: > > > > +struct tegra_sha_reqctx { > > + struct ahash_request fallback_req; > > This doesn't work because ahash_request is dynamically sized. > So you'll end up clobbering the rest of the struct if a fallback ends up being used. > > You should place the fallback_req at the end of the reqctx and set the reqsize > based on the fallback reqsize. > Should I set the reqsize as below in sha_cra_init()? Seeing this in other crypto drivers.
crypto_ahash_set_reqsize(ahash_tfm, sizeof(struct tegra_sha_reqctx) + crypto_ahash_reqsize(ctx->fallback_tfm));
Regards, Akhil
| |