Messages in this thread | | | Date | Tue, 2 Apr 2024 13:23:19 +0200 | From | Michal Koutný <> | Subject | Re: Re: [PATCH v9 15/15] selftests/sgx: Add scripts for EPC cgroup testing |
| |
Hello.
On Sat, Mar 30, 2024 at 01:26:08PM +0200, Jarkko Sakkinen <jarkko@kernel.org> wrote: > > > It'd be more complicated and less readable to do all the stuff without the > > > cgroup-tools, esp cgexec. I checked dependency, cgroup-tools only depends > > > on libc so I hope this would not cause too much inconvenience. > > > > As per cgroup-tools, please prove this. It makes the job for more > > complicated *for you* and you are making the job more complicated > > to every possible person in the planet running any kernel QA. > > > > I weight the latter more than the former. And it is exactly the > > reason why we did custom user space kselftest in the first place. > > Let's keep the tradition. All I can say is that kselftest is > > unfinished in its current form. > > > > What is "esp cgexec"? > > Also in kselftest we don't drive ultimate simplicity, we drive > efficient CI/QA. By open coding something like subset of > cgroup-tools needed to run the test you also help us later > on to backtrack the kernel changes. With cgroups-tools you > would have to use strace to get the same info.
FWIW, see also functions in tools/testing/selftests/cgroup/cgroup_util.{h,c}. They likely cover what you need already -- if the tests are in C.
(I admit that stuff in tools/testing/selftests/cgroup/ is best understood with strace.)
HTH, Michal [unhandled content-type:application/pgp-signature] | |