Messages in this thread | | | Date | Tue, 2 Apr 2024 12:08:31 +0530 | Subject | Re: [PATCH v5 09/10] drm/ci: rockchip: Add job to test panfrost GPU driver | From | Vignesh Raman <> |
| |
Hi Helen,
On 01/04/24 22:13, Helen Koike wrote: > > > On 01/04/2024 03:12, Vignesh Raman wrote: >> For rockchip rk3288 and rk3399, the GPU driver is panfrost. >> So add support in drm-ci to test panfrost driver for rockchip >> SOC and update xfails. Skip KMS tests for panfrost driver >> since it is not a not a KMS driver and skip driver-specific tests. >> >> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > > Btw, just a nit, I would squash this with the previous commit, so we > don't have a point in history with panfrost tests, than without them, > than with them again. But with or without this change: > > Acked-by: Helen Koike <helen.koike@collabora.com>
Maybe I will move the skipping kms tests and other driver specific tests to the previous commit.
Regards, Vignesh
> > Thanks > Helen > >> --- >> >> v2: >> - Add panfrost GPU jobs for rockchip SOC with new xfails. >> >> v3: >> - Skip KMS tests for panfrost driver since it is not a not >> a KMS driver and update xfails. Add the job name in GPU_VERSION >> and use it for xfail file names instead of using DRIVER_NAME. >> >> v4: >> - Remove the gpu suffix in job and rename xfails accordingly. >> >> v5: >> - Skip driver-specific tests. >> >> --- >> drivers/gpu/drm/ci/test.yml | 10 ++++++++++ >> drivers/gpu/drm/ci/xfails/panfrost-rk3288-fails.txt | 1 + >> drivers/gpu/drm/ci/xfails/panfrost-rk3288-skips.txt | 8 ++++++++ >> drivers/gpu/drm/ci/xfails/panfrost-rk3399-fails.txt | 1 + >> drivers/gpu/drm/ci/xfails/panfrost-rk3399-skips.txt | 8 ++++++++ >> 5 files changed, 28 insertions(+) >> create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-rk3288-fails.txt >> create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-rk3288-skips.txt >> create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-rk3399-fails.txt >> create mode 100644 drivers/gpu/drm/ci/xfails/panfrost-rk3399-skips.txt >> >> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml >> index 96b299c32c07..8c90ae5a51e6 100644 >> --- a/drivers/gpu/drm/ci/test.yml >> +++ b/drivers/gpu/drm/ci/test.yml >> @@ -191,11 +191,21 @@ rockchip:rk3288: >> - .rk3288 >> - .rockchip-display >> +panfrost:rk3288: >> + extends: >> + - .rk3288 >> + - .panfrost-gpu >> + >> rockchip:rk3399: >> extends: >> - .rk3399 >> - .rockchip-display >> +panfrost:rk3399: >> + extends: >> + - .rk3399 >> + - .panfrost-gpu >> + >> .i915: >> extends: >> - .lava-igt:x86_64 >> diff --git a/drivers/gpu/drm/ci/xfails/panfrost-rk3288-fails.txt >> b/drivers/gpu/drm/ci/xfails/panfrost-rk3288-fails.txt >> new file mode 100644 >> index 000000000000..abd35a8ef6f4 >> --- /dev/null >> +++ b/drivers/gpu/drm/ci/xfails/panfrost-rk3288-fails.txt >> @@ -0,0 +1 @@ >> +panfrost_prime@gem-prime-import,Crash >> diff --git a/drivers/gpu/drm/ci/xfails/panfrost-rk3288-skips.txt >> b/drivers/gpu/drm/ci/xfails/panfrost-rk3288-skips.txt >> new file mode 100644 >> index 000000000000..41a846a59644 >> --- /dev/null >> +++ b/drivers/gpu/drm/ci/xfails/panfrost-rk3288-skips.txt >> @@ -0,0 +1,8 @@ >> +# Panfrost is not a KMS driver, so skip the KMS tests >> +kms_.* >> + >> +# Skip driver specific tests >> +msm_.* >> +^amdgpu.* >> +v3d_.* >> +vc4_.* >> diff --git a/drivers/gpu/drm/ci/xfails/panfrost-rk3399-fails.txt >> b/drivers/gpu/drm/ci/xfails/panfrost-rk3399-fails.txt >> new file mode 100644 >> index 000000000000..6f5e760d5ec0 >> --- /dev/null >> +++ b/drivers/gpu/drm/ci/xfails/panfrost-rk3399-fails.txt >> @@ -0,0 +1 @@ >> +panfrost_prime@gem-prime-import,Fail >> diff --git a/drivers/gpu/drm/ci/xfails/panfrost-rk3399-skips.txt >> b/drivers/gpu/drm/ci/xfails/panfrost-rk3399-skips.txt >> new file mode 100644 >> index 000000000000..41a846a59644 >> --- /dev/null >> +++ b/drivers/gpu/drm/ci/xfails/panfrost-rk3399-skips.txt >> @@ -0,0 +1,8 @@ >> +# Panfrost is not a KMS driver, so skip the KMS tests >> +kms_.* >> + >> +# Skip driver specific tests >> +msm_.* >> +^amdgpu.* >> +v3d_.* >> +vc4_.*
| |