Messages in this thread | | | Date | Tue, 2 Apr 2024 14:30:57 +0800 | From | Xu Yilun <> | Subject | Re: [PATCH] fpga: altera-cvp: Remove an unused field in struct altera_cvp_conf |
| |
On Mon, Apr 01, 2024 at 03:08:21PM +0200, Christophe JAILLET wrote: > In "struct altera_cvp_conf", the 'mgr' field is unused. > Remove it. > > Found with cppcheck, unusedStructMember. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied to for-next.
> --- > Apparently, it has never been used. It is not a left-over from a > refactoring. > > The address of the 'fpga_manager' is handled via pci_[s|g]et_drvdata(). > > Compile tested only. > --- > drivers/fpga/altera-cvp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c > index 4ffb9da537d8..6b0914432445 100644 > --- a/drivers/fpga/altera-cvp.c > +++ b/drivers/fpga/altera-cvp.c > @@ -72,7 +72,6 @@ static bool altera_cvp_chkcfg; > struct cvp_priv; > > struct altera_cvp_conf { > - struct fpga_manager *mgr; > struct pci_dev *pci_dev; > void __iomem *map; > void (*write_data)(struct altera_cvp_conf *conf, > -- > 2.44.0 > >
| |