lkml.org 
[lkml]   [2024]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net v3] net: usb: ax88179_178a: avoid the interface always configured as random address
On Mon,  1 Apr 2024 10:19:50 +0200 Jose Ignacio Tornos Martinez wrote:
> if (is_valid_ether_addr(mac)) {
> eth_hw_addr_set(dev->net, mac);
> + dev->net->addr_assign_type = NET_ADDR_PERM;

Are we 100% sure we won't read back the random address we wrote earlier?
Maybe let's put the assignment under if (!is_local_ether_addr(mac)),
just to be on the safe side?

\
 
 \ /
  Last update: 2024-05-27 16:20    [W:0.102 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site