lkml.org 
[lkml]   [2024]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] arm64: tegra: correct Tegra132 I2C alias
From

On 01/04/2024 15:08, Krzysztof Kozlowski wrote:
> There is no such device as "as3722@40", because its name is "pmic". Use
> phandles for aliases to fix relying on full node path. This corrects
> aliases for RTC devices and also fixes dtc W=1 warning:
>
> tegra132-norrin.dts:12.3-36: Warning (alias_paths): /aliases:rtc0: aliases property is not a valid node (/i2c@7000d000/as3722@40)
>
> Fixes: 0f279ebdf3ce ("arm64: tegra: Add NVIDIA Tegra132 Norrin support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++--
> arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> index 14d58859bb55..683ac124523b 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> @@ -9,8 +9,8 @@ / {
> compatible = "nvidia,norrin", "nvidia,tegra132", "nvidia,tegra124";
>
> aliases {
> - rtc0 = "/i2c@7000d000/as3722@40";
> - rtc1 = "/rtc@7000e000";
> + rtc0 = &as3722;
> + rtc1 = &tegra_rtc;
> serial0 = &uarta;
> };
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> index 7e24a212c7e4..5bcccfef3f7f 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> @@ -572,7 +572,7 @@ spi@7000de00 {
> status = "disabled";
> };
>
> - rtc@7000e000 {
> + tegra_rtc: rtc@7000e000 {
> compatible = "nvidia,tegra124-rtc", "nvidia,tegra20-rtc";
> reg = <0x0 0x7000e000 0x0 0x100>;
> interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

--
nvpublic

\
 
 \ /
  Last update: 2024-05-27 16:19    [W:0.047 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site