Messages in this thread | | | Date | Tue, 2 Apr 2024 18:58:24 +0200 | From | Francesco Dolcini <> | Subject | Re: [PATCH] arm64: dts: ti: k3-j722s: Disable ethernet ports by default |
| |
Hello Michael,
On Tue, Apr 02, 2024 at 05:18:02PM +0200, Michael Walle wrote: > Device tree best practice is to disable any external interface in the > dtsi and just enable them if needed in the device tree. Thus, disable > both ethernet ports by default and just enable the one used by the EVM > in its device tree. > > There is no functional change. > > Signed-off-by: Michael Walle <mwalle@kernel.org> > --- > This should also be true for all the other SoCs. But I don't wanted to > touch all the (older) device trees. j722s is pretty new, so there we > should get it right. > --- > arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 5 +---- > arch/arm64/boot/dts/ti/k3-j722s.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > index d045dc7dde0c..afe7f68e6a4b 100644 > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > @@ -224,14 +224,11 @@ cpsw3g_phy0: ethernet-phy@0 { > }; > > &cpsw_port1 { > + status = "okay";
status should be the last property, according to the dts coding guidelines.
> phy-mode = "rgmii-rxid"; > phy-handle = <&cpsw3g_phy0>; > };
Francesco
| |