Messages in this thread | | | Date | Tue, 2 Apr 2024 18:04:20 +0200 (CEST) | From | Romain Gantois <> | Subject | Re: [PATCH net-next 2/3] net: stmmac: add support for RZ/N1 GMAC |
| |
Hello Russell,
On Tue, 2 Apr 2024, Russell King (Oracle) wrote:
> > I'm afraid that this fails at one of the most basic principles of kernel > > multi-threaded programming. stmmac_dvr_probe() as part of its work calls > > register_netdev() which publishes to userspace the network device. > > > > Everything that is required must be setup _prior_ to publication to > > userspace to avoid races, because as soon as the network device is > > published, userspace can decide to bring that interface up. If one > > hasn't finished the initialisation, the interface can be brought up > > before that initialisation is complete. .. > > I'm not going to say that the two patches threaded to this email are > "sane" but at least it avoids the problem. socfpga still has issues > with initialisation done after register_netdev() though.
Thanks a lot for providing a fix to this issue, introducing new pcs_init/exit() hooks seems like the best solution at this time, I'll make sure to integrate those patches in the v2 for this series.
Thanks,
-- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |