Messages in this thread | | | Date | Fri, 19 Apr 2024 09:51:52 -0700 | From | Shradha Gupta <> | Subject | Re: [PATCH v2] Add a header in ifcfg and nm keyfiles describing the owner of the files |
| |
On Thu, Apr 18, 2024 at 07:01:20PM +0000, Dexuan Cui wrote: > > From: Easwar Hariharan <eahariha@linux.microsoft.com> > > Sent: Thursday, April 18, 2024 9:16 AM > > > > On 4/18/2024 5:05 AM, Ani Sinha wrote: > > > A comment describing the source of writing the contents of the ifcfg and > > > network manager keyfiles (hyperv kvp daemon) is useful. It is valuable > > s/hyperv/Hyper-V/ > > > > +#define CFG_HEADER "# Generated by hyperv key-value pair daemon. > > Please do not modify.\n" > > s/hyperv/Hyper-V/ > > > Looks good to me, I'll defer to other folks on the recipient list on whether > > "hyperv" should be capitalized as HyperV or other such feedback. > > It's recommended to use "Hyper-V". Wei can help fix this so I guess > there is no need to resend the patch :-) Sounds good!
| |