Messages in this thread | | | From | Ian Rogers <> | Date | Fri, 19 Apr 2024 07:40:54 -0700 | Subject | Re: [PATCH v1] perf test: Avoid hard coded metrics in stat std output test |
| |
On Fri, Apr 19, 2024 at 6:54 AM Liang, Kan <kan.liang@linux.intel.com> wrote: > > > > On 2024-04-17 2:32 p.m., Ian Rogers wrote: > > Hard coded metric names fail on ARM testing. > > > > Signed-off-by: Ian Rogers <irogers@google.com> > > --- > > tools/perf/tests/shell/stat+std_output.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/tests/shell/stat+std_output.sh b/tools/perf/tests/shell/stat+std_output.sh > > index cbf2894b2c84..845f83213855 100755 > > --- a/tools/perf/tests/shell/stat+std_output.sh > > +++ b/tools/perf/tests/shell/stat+std_output.sh > > @@ -13,7 +13,7 @@ stat_output=$(mktemp /tmp/__perf_test.stat_output.std.XXXXX) > > > > event_name=(cpu-clock task-clock context-switches cpu-migrations page-faults stalled-cycles-frontend stalled-cycles-backend cycles instructions branches branch-misses) > > event_metric=("CPUs utilized" "CPUs utilized" "/sec" "/sec" "/sec" "frontend cycles idle" "backend cycles idle" "GHz" "insn per cycle" "/sec" "of all branches") > > -skip_metric=("stalled cycles per insn" "tma_" "retiring" "frontend_bound" "bad_speculation" "backend_bound") > > +skip_metric=($(perf list --raw Default 2> /dev/null)) > > > The "perf list --raw Default" only gives the topdown metrics. > The "stalled cycles per insn" is not covered. > The check should skip the line of "stalled cycles per insn" as well. > > 3,856,436,920 stalled-cycles-frontend # 74.09% frontend cycles idle > 1,600,790,871 stalled-cycles-backend # 30.75% backend cycles idle > 2,603,501,247 instructions # 0.50 insns per cycle > # 1.48 stalled cycles > per insn > 484,357,498 branches # 283.455 M/sec > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/builtin-stat.c#n24 > > The newer Intel CPU doesn't have the stalled-cycles-* events. But it > seems power and older x86 CPU have the events.
Oh, sigh. This test should really ignore lines like that. How much do we care about these metrics? The RISC-V event parsing change: https://lore.kernel.org/lkml/20240416061533.921723-1-irogers@google.com/ means that legacy hardware events will be uncommon and we need to adapt the hard coded metrics in stat-shadow.c to json ones. Once they are json metrics they will be in Default.
Thanks, Ian
> Thanks, > Kan > > > > > cleanup() { > > rm -f "${stat_output}"
| |