Messages in this thread | | | Date | Fri, 19 Apr 2024 07:13:50 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 0/5] Remove onstack cpumask var usage |
| |
Hi Dawei,
On Thu, Apr 18, 2024 at 06:49:44PM +0800, Dawei Li wrote: > Hi, > > This series aims at removing on-stack cpumask var usage for sparc arch. > > Generally it's preferable to avoid placing cpumasks on the stack, as > for large values of NR_CPUS these can consume significant amounts of > stack space and make stack overflows more likely.
Took a quick look at the patches, looks good except the one the bot already complained about. A quick grep shows a few more cases where we have an on-stack cpumask in sparc code.
kernel/ds.c: cpumask_t mask; kernel/leon_kernel.c: cpumask_t mask; kernel/leon_smp.c:static void leon_cross_call(void *func, cpumask_t mask, unsigned long arg1, kernel/sun4d_smp.c:static void sun4d_cross_call(void *func, cpumask_t mask, unsigned long arg1,
Do you plan to look at the other on-stack users too? It would be nice to see them all gone in one patch-set.
Sam
| |