Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH 1/2] cpu: Re-enable CPU mitigations by default for !X86 architectures | Date | Thu, 18 Apr 2024 10:54:28 +1000 |
| |
Sean Christopherson <seanjc@google.com> writes: > Add a generic Kconfig, CPU_MITIGATIONS, to control whether or not CPU > mitigations are enabled by default, and force it on for all architectures > except x86. A recent commit to turn mitigations off by default if > SPECULATION_MITIGATIONS=n kinda sorta missed that "cpu_mitigations" is > completely generic, where as SPECULATION_MITIGATIONS is x86 specific. > > Alternatively, SPECULATION_MITIGATIONS could simply be defined in common > code, but that creates weirdness for x86 because SPECULATION_MITIGATIONS > ends up being defined twice, and the default behavior would likely depend > on the arbitrary include order (if the two definitions diverged). > > Ideally, CPU_MITIGATIONS would be unconditionally on by default for all > architectures, and manually turned off, but there is no way to unselect a > Kconfig. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Reported-by: Michael Ellerman <mpe@ellerman.id.au> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Closes: https://lkml.kernel.org/r/20240413115324.53303a68%40canb.auug.org.au > Fixes: f337a6a21e2f ("x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n") > Cc: stable@vger.kernel.org > Signed-off-by: Sean Christopherson <seanjc@google.com> > ---
Thanks for fixing it up.
Tested-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
| |