Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n | Date | Thu, 18 Apr 2024 23:01:25 +1000 |
| |
"Arnd Bergmann" <arnd@arndb.de> writes: > On Thu, Apr 18, 2024, at 08:26, Michael Ellerman wrote: >> Arnd Bergmann <arnd@kernel.org> writes: > >> @@ -692,6 +692,7 @@ static inline void name at >> \ >> #define writesw writesw >> #define writesl writesl >> >> +#ifdef CONFIG_HAS_IOPORT >> #define inb inb >> #define inw inw >> #define inl inl >> @@ -704,6 +705,8 @@ static inline void name at >> \ >> #define outsb outsb >> #define outsw outsw >> #define outsl outsl >> +#endif // CONFIG_HAS_IOPORT >> + >> #ifdef __powerpc64__ >> #define readq readq >> #define writeq writeq > > I had included this at first, but then I still ran into > the same warnings because it ends up pulling in the > generic outsb() etc from include/asm-generic/io.h > that relies on setting a non-NULL PCI_IOBASE.
Yes you're right. The above fixes the gcc build, but not clang.
So I think I'll just cherry pick f0a816fb12da ("/dev/port: don't compile file operations without CONFIG_DEVPORT") into my next and then apply this. But will see if there's any other build failures over night.
cheers
| |