lkml.org 
[lkml]   [2024]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v3 1/9] PCI: qcom-ep: Disable resources unconditionally during PERST# assert
    All EP specific resources are enabled during PERST# deassert. As a counter
    operation, all resources should be disabled during PERST# assert. There is
    no point in skipping that if the link was not enabled.

    This will also result in enablement of the resources twice if PERST# got
    deasserted again. So remove the check from qcom_pcie_perst_assert() and
    disable all the resources unconditionally.

    Fixes: f55fee56a631 ("PCI: qcom-ep: Add Qualcomm PCIe Endpoint controller driver")
    Reviewed-by: Niklas Cassel <cassel@kernel.org>
    Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    ---
    drivers/pci/controller/dwc/pcie-qcom-ep.c | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c
    index 2fb8c15e7a91..50b1635e3cbb 100644
    --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
    +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
    @@ -500,12 +500,6 @@ static int qcom_pcie_perst_deassert(struct dw_pcie *pci)
    static void qcom_pcie_perst_assert(struct dw_pcie *pci)
    {
    struct qcom_pcie_ep *pcie_ep = to_pcie_ep(pci);
    - struct device *dev = pci->dev;
    -
    - if (pcie_ep->link_status == QCOM_PCIE_EP_LINK_DISABLED) {
    - dev_dbg(dev, "Link is already disabled\n");
    - return;
    - }

    dw_pcie_ep_cleanup(&pci->ep);
    qcom_pcie_disable_resources(pcie_ep);
    --
    2.25.1


    \
     
     \ /
      Last update: 2024-04-18 13:59    [W:4.099 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site