Messages in this thread | | | From | Danielle Ratson <> | Subject | RE: [PATCH net-next v3 07/10] ethtool: cmis_cdb: Add a layer for supporting CDB commands | Date | Thu, 18 Apr 2024 10:31:58 +0000 |
| |
> -----Original Message----- > From: Simon Horman <horms@kernel.org> > Sent: Thursday, 18 April 2024 12:46 > To: Danielle Ratson <danieller@nvidia.com> > Cc: netdev@vger.kernel.org; davem@davemloft.net; edumazet@google.com; > kuba@kernel.org; pabeni@redhat.com; corbet@lwn.net; > linux@armlinux.org.uk; sdf@google.com; kory.maincent@bootlin.com; > maxime.chevallier@bootlin.com; vladimir.oltean@nxp.com; > przemyslaw.kitszel@intel.com; ahmed.zaki@intel.com; > richardcochran@gmail.com; shayagr@amazon.com; > paul.greenwalt@intel.com; jiri@resnulli.us; linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; mlxsw <mlxsw@nvidia.com>; Petr Machata > <petrm@nvidia.com>; Ido Schimmel <idosch@nvidia.com> > Subject: Re: [PATCH net-next v3 07/10] ethtool: cmis_cdb: Add a layer for > supporting CDB commands > > On Wed, Apr 17, 2024 at 11:53:44AM +0300, Danielle Ratson wrote: > > ... > > > +/** > > + * struct ethtool_cmis_cdb_cmd_args - CDB commands execution > > +arguments > > + * @req: CDB command fields as described in the CMIS standard. > > + * @max_duration: Maximum duration time for command completion in > msec. > > + * @read_write_len_ext: Allowable additional number of byte octets to > the LPL > > + * in a READ or a WRITE commands. > > + * @rpl_exp_len: Expected reply length in bytes. > > + * @flags: Validation flags for CDB commands. > > + */ > > Hi Danielle, > > I'm fine if this gets addressed as a follow-up, but the Kernel doc above should > include documentation of msleep_pre_rpl and err_msg. > > Flagged by: ./scripts/kernel-doc -Wall -none
Hi Simon,
Thanks for the comment. Ill send a new version.
Danielle
> > > +struct ethtool_cmis_cdb_cmd_args { > > + struct ethtool_cmis_cdb_request req; > > + u16 max_duration; > > + u8 read_write_len_ext; > > + u8 msleep_pre_rpl; > > + u8 rpl_exp_len; > > + u8 flags; > > + char *err_msg; > > +}; > > ...
| |