Messages in this thread | | | Date | Thu, 18 Apr 2024 01:04:11 +0200 | From | Frederic Weisbecker <> | Subject | Re: [patch V2 11/50] posix-cpu-timers: Handle SIGEV_NONE timers correctly in timer_set() |
| |
Le Fri, Apr 12, 2024 at 12:02:28AM +0200, Thomas Gleixner a écrit : > On Thu, Apr 11 2024 at 17:48, Anna-Maria Behnsen wrote: > > > Thomas Gleixner <tglx@linutronix.de> writes: > > > >> Expired SIGEV_NONE oneshot timers must return 0 nsec for the expiry time in > >> timer_get(), but the posix CPU timer implementation returns 1 nsec. > > > > copy paste error (get/set) ? > > Yes. > > >> Add the missing conditional. > >> > >> This will be cleaned up in a follow up patch. > > > > I'm confused. Why do you want to cleanup the conditional in a follow up > > patch? > > This patch is to fix the issue. The next one consolidates the code, but > I can see why the "this will be ..." part of the changelog does not make > sense.
But please keep it cut that way. FWIW it's much easier to review than the previous take. That way we aren't missing subtle changes.
| |