lkml.org 
[lkml]   [2024]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 7/8] mm: drop page_index/page_file_offset and convert swap helpers to use folio
On Thu, Apr 18, 2024 at 3:31 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Thu, Apr 18, 2024 at 01:55:28PM +1200, Barry Song wrote:
> > I also find it rather odd that folio_file_page() is utilized for both
> > swp and file.
> >
> > mm/memory.c <<do_swap_page>>
> > page = folio_file_page(folio, swp_offset(entry));
> > mm/swap_state.c <<swapin_readahead>>
> > return folio_file_page(folio, swp_offset(entry));
> > mm/swapfile.c <<unuse_pte>>
> > page = folio_file_page(folio, swp_offset(entry));
> >
> > Do you believe it's worthwhile to tidy up?
>
> Why do you find it odd? What would you propose instead?

i'd prefer something like folio_swap_page(folio, entry);

\
 
 \ /
  Last update: 2024-04-18 05:55    [W:0.057 / U:1.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site