Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 18 Apr 2024 14:27:16 -0700 | From | Isaku Yamahata <> | Subject | Re: [PATCH v19 111/130] KVM: TDX: Implement callbacks for MSR operations for TDX |
| |
On Thu, Apr 18, 2024 at 09:54:39PM +0800, Binbin Wu <binbin.wu@linux.intel.com> wrote:
> > > On 2/26/2024 4:26 PM, isaku.yamahata@intel.com wrote: > > From: Isaku Yamahata <isaku.yamahata@intel.com> > > > > Implements set_msr/get_msr/has_emulated_msr methods for TDX to handle > > hypercall from guest TD for paravirtualized rdmsr and wrmsr. The TDX > > module virtualizes MSRs. For some MSRs, it injects #VE to the guest TD > > upon RDMSR or WRMSR. The exact list of such MSRs are defined in the spec. > > > > Upon #VE, the guest TD may execute hypercalls, > > TDG.VP.VMCALL<INSTRUCTION.RDMSR> and TDG.VP.VMCALL<INSTRUCTION.WRMSR>, > > which are defined in GHCI (Guest-Host Communication Interface) so that the > > host VMM (e.g. KVM) can virtualize the MSRs. > > > > There are three classes of MSRs virtualization. > > - non-configurable: TDX module directly virtualizes it. VMM can't > > configure. the value set by KVM_SET_MSR_INDEX_LIST is ignored. > > There is no KVM_SET_MSR_INDEX_LIST in current kvm code. > Do you mean KVM_SET_MSRS?
Yes, will fix it. Thank you for catching it. -- Isaku Yamahata <isaku.yamahata@intel.com>
| ![\](/images/icornerr.gif) |