lkml.org 
[lkml]   [2024]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] workqueue: fix selection of wake_cpu in kick_pool()
On Thu, Apr 18, 2024 at 07:54:37AM +0200, Sven Schnelle wrote:
> Tejun Heo <tj@kernel.org> writes:
>
> > Hello,
> >
> > On Wed, Apr 17, 2024 at 05:36:38PM +0200, Sven Schnelle wrote:
> >> > This generally seems like a good idea but isn't this still racy? The CPU may
> >> > go down between setting p->wake_cpu and wake_up_process().
> >>
> >> Don't know without reading the source, but how does this code normally
> >> protect against that?
> >
> > Probably by wrapping determining the wake_cpu and the wake_up inside
> > cpu_read_lock() section.
>
> Thanks. Should i send a v2 and incorporate your additional changes or do
> you want to do that?

Yes, please send a v2.

Thanks.

--
tejun

\
 
 \ /
  Last update: 2024-04-18 17:56    [W:0.068 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site